Update return type for EVP_EncodeUpdate #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
- Coverage 77.05% 76.97% -0.08%
==========================================
Files 425 425
Lines 71627 71631 +4
==========================================
- Hits 55190 55140 -50
- Misses 16437 16491 +54 ☔ View full report in Codecov by Sentry. |
smittals2
previously approved these changes
Mar 8, 2024
samuel40791765
force-pushed
the
update-evp-update
branch
from
9139cf7
to
3e5513f
Compare
andrewhop
approved these changes
Mar 11, 2024
smittals2
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
tpm2-tools expects
EVP_EncodeUpdateto return an integer, instead of being a void function: tpm2-software/tpm2-tools@54a4178.Apparently the return type of this has been updated since OpenSSL 1.1.0: openssl/openssl@cf3404f It seems worth updating to align with upstream.
Call-outs:
N/A
Testing:
Slightly modified the existing test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.